Disable time tracking in wasm release builds because it's expensive #99841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @SamMonoRT, @vargaz |
|
Tagging subscribers to 'arch-wasm': @lewing |
vargaz
approved these changes
Mar 15, 2024
steveisok
approved these changes
Mar 15, 2024
lambdageek
reviewed
Mar 15, 2024
This was referenced Mar 16, 2024
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
Mar 16, 2024
|
This passed CI a couple times previously, so even though the lanes aren't working right now, is it fine to merge it? |
maraf
approved these changes
Mar 18, 2024
|
nice, it helped with the startup indeed https://radekdoulik.github.io/WasmPerformanceMeasurements/?startDate=2024-03-12T10%3A19%3A36.040Z&endDate=2024-03-19T10%3A19%3A36.040Z&tasks=AppStart 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now on main we spend a good chunk of cpu time just calling _emscripten_get_now in order to measure how long interpreter code generation takes. On most targets the equivalent timestamp checks are fast but on wasm, they're not.
So this PR disables those checks in wasm release builds specifically. Based on my measurements this should improve startup time a little bit.