Fix detection of exceptionally called funclet in stack walk #99958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with stack walking detecting funclets called during exception handling with the new EH enabled. The code was considering any funclet it found below the topmost ExInfo, but I have not realized it can also hit non-exceptionally called finallys. Those don't have any exception handling going on and thus are incorrectly used for storing information that it used later at the parent to track GC references. We need to consider only funclets that were called exceptionally.
|
@jkotas this was being hit only in a test executed with |
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr jitstress2-jitstressregs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mangod9
approved these changes
Mar 19, 2024
3 tasks
jkotas
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with stack walking detecting funclets called during exception handling with the new EH enabled. The code was considering any funclet it found below the topmost
ExInfo, but I have not realized it can also hit non-exceptionally called finallys. Those don't have any exception handling going on and thus are incorrectly used for storing information that it used later at the parent to track GC references. We need to consider only funclets that were called exceptionally.Close #99884