Forward special P/Invoke attributes to the target DllImport method #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emitted DllImport entry point.
jkoritzinsky
added
the
area-DllImportGenerator
|
@AaronRobinsonMSFT looks like Clang warns about unused attributes (like calling conventions on x64), and since Clang uses a pretty standard warning format, MSBuild recognizes it and elevates it to an error since we have WarnAsError set to true. Is there an easy way to suppress the warning from DNNE? Also, is it worth having integration tests for the calling convention work since we validate that we forwarded the attribute in the unit tests and the calling conventions would only have a difference in x86, which we don't run against? |
|
Updated DNNE to avoid setting these values - https://www.nuget.org/packages/DNNE/1.0.22. |
AaronRobinsonMSFT
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the GeneratedDllImport-attributed method has SuppressGCTransition or UnmanagedCallConv attributes, apply the attributes to the generated DllImport method.