NativeAOT-LLVM: Add void to .c functions that have no parameters - something about K&R functions?? #2004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this warning which seems to be new in later versions of clang. Interestingly runtime doesn't have this fix, so don't know how that is working, maybe its not on the later versions of clang yet. If the header declares the args as
void
the.c
needs to do the same to avoid the warning. At least that's my observation...https://reviews.llvm.org/D122895
Might be relevant, there's a mention of void in the comments.