Fix native library sample #270
Conversation
|
|
| @@ -63,10 +63,6 @@ The .NET Foundation licenses this file to you under the MIT license. | |||
| <NativeLibrary Include="crypt32.lib" /> | |||
| </ItemGroup> | |||
|
|
|||
| <PropertyGroup> | |||
| <IlcProcessEntrypoint Condition="$(IlcProcessEntrypoint) == ''">wmainCRTStartup</IlcProcessEntrypoint> | |||
There was a problem hiding this comment.
I have started by introducing another variable for the SharedLib init entrypoint, but then decided against it as unnecessary abstraction. I think we should wait for a real case why it is useful.
There was a problem hiding this comment.
It would be useful for the @kant2002 inspired project file of my Doom fire effect: https://github.com/MichalStrehovsky/sharpfire/blob/fee39991c22b39d263933d0fd1ec25d585d82e6e/nogui.csproj#L4 (that's why I added option to set your own entrypoint when I was messing with it).
I had to avoid specifying WinExe because then the entrypoint gets set up from here and breaks things.
Arguably I never ended up using it because I have better things to do than maintaining my old hacks :).
Two weeks after the hack I learned about /ALTERNATENAME that can be used for this too I guess.
I don't particularly care, just wanted to share the history.
There was a problem hiding this comment.
Actually we might be able to use /ALTERNATENAME to remove the need for the /ENTRY line.
Something like /ALTERNATENAME:wWinMainCRTStartup=wmainCRTStartup should also do the trick and we don't even need to condition it on WinExe.
There was a problem hiding this comment.
I have left it as is. The ALTERNATENAME trick is neat, but i did not look like an improvement to me.
jkotas
added
the
area-NativeAOT-coreclr
Undoes workaround from dotnet/runtimelab#270. Since bootstrapper no longer ships as a static library (it's an object file instead), we should no longer need this hack to force linker into looking at the archive.
Undoes workaround from dotnet/runtimelab#270. Since bootstrapper no longer ships as a static library (it's an object file instead), we should no longer need this hack to force linker into looking at the archive.
No description provided.