Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report generator diagnostic when trying to target pre-.NET 5.0 #276

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Report generator diagnostic when trying to target pre-.NET 5.0 #276

merged 5 commits into from
Oct 30, 2020

Conversation

elinor-fung
Copy link
Member

  • Move rules list to unshipped for analyzer release tracking and update category for generator diagnostics
  • Add diagnostic for using P/Invoke source generator when targeting pre-.NET 5.0
  • Add tests

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Oct 30, 2020
jkoritzinsky
jkoritzinsky approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elinor-fung elinor-fung merged commit 87da2fd into dotnet:feature/DllImportGenerator Oct 30, 2020
@elinor-fung elinor-fung deleted the targetFrameworkNotSupported branch October 30, 2020 06:40
jkoritzinsky pushed a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
@elinor-fung
Report generator diagnostic when trying to target pre-.NET 5.0 (dotne…
0a073bd 
…t/runtimelab#276)

Commit migrated from dotnet/runtimelab@87da2fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkoritzinsky @AaronRobinsonMSFT