Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting for some diagnostic messages #311

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Fix formatting for some diagnostic messages #311

merged 2 commits into from
Nov 13, 2020

Conversation

elinor-fung
Copy link
Member

  • Fix some message formats
    • Removed the parameter names in the array size messages instead of updating to format with the correct arguments because the full message will already include the parameter / method name (switching on if it is for a parameter or return value).
  • Reorganize some unit test cases

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Nov 6, 2020
@elinor-fung elinor-fung merged commit 3e23af1 into dotnet:feature/DllImportGenerator Nov 13, 2020
@elinor-fung elinor-fung deleted the fixMessages branch November 13, 2020 01:33
jkoritzinsky pushed a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
@elinor-fung
Fix formatting for some diagnostic messages (dotnet/runtimelab#311)
1719a7c 
Commit migrated from dotnet/runtimelab@3e23af1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkoritzinsky @AaronRobinsonMSFT