Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DynamicallyAccessedMembers attribute to CreateSafeHandle API #373

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Add DynamicallyAccessedMembers attribute to CreateSafeHandle API #373

merged 2 commits into from
Nov 21, 2020

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Nov 20, 2020
@elinor-fung elinor-fung changed the title Add DynamicallyAccessedMembers to CreateSafeHandle API Add DynamicallyAccessedMembers attribute to CreateSafeHandle API Nov 20, 2020
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure when the API review occurs we capture this. Perhaps we can add a summary or remarks tag on this type capturing some of the questions/concerns to bring up during the API review?

@elinor-fung elinor-fung merged commit e4bdc07 into dotnet:feature/DllImportGenerator Nov 21, 2020
@elinor-fung elinor-fung deleted the linkerAttribute branch November 21, 2020 03:43
jkoritzinsky pushed a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
@elinor-fung
Add DynamicallyAccessedMembers attribute to CreateSafeHandle API (dot…
e82452d 
…net/runtimelab#373)

Commit migrated from dotnet/runtimelab@e4bdc07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkoritzinsky @AaronRobinsonMSFT