Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Environment.ProcessorCount - port dotnet/runtime#45943 #598

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Update Environment.ProcessorCount - port dotnet/runtime#45943 #598

merged 2 commits into from
Jan 28, 2021

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 27, 2021

Also delete some dead code

@jkotas jkotas changed the title Update Environment.ProcessorCount - port dotnet/rutnime#45943 Update Environment.ProcessorCount - port dotnet/runtime#45943 Jan 27, 2021
@jkotas
Update Environment.ProcessorCount on Windows to take into account t…
8521230 
…he processor affinity mask

Port of dotnet/runtime#45943

Delete some dead code
@jkotas
Copy link
Member Author

jkotas commented Jan 27, 2021

I have verified that Environment.ProcessorCount takes process affinity into account with this change.

MichalStrehovsky
MichalStrehovsky approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Show resolved Hide resolved
@MichalStrehovsky MichalStrehovsky merged commit e28a392 into dotnet:feature/NativeAOT Jan 28, 2021
@jkotas jkotas deleted the cpucount branch January 28, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @MichalStrehovsky