[release/9.0.2xx] Allow ProjectReferences to not have the _GetRequire…

…dWorkloads Target (#44701)

Co-authored-by: Chet Husk <chusk3@gmail.com>
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.ImportWorkloads.targets

@@ -42,14 +42,17 @@ Copyright (c) .NET Foundation. All rights reserved.
   </Target>
 
   <!--  This target is not part of the build. Only used by dotnet workload restore command. Global property "SkipResolvePackageAssets"
-        need to be set to "true" to avoid requiring restore (which would likely fail if the required workloads aren't already installed).-->
+        need to be set to "true" to avoid requiring restore (which would likely fail if the required workloads aren't already installed).
+        In addition, since this is a target that is called on potentially-unsupported project types like esproj, we need to not fail
+        if the Target is missing. -->
   <Target Name="_GetRequiredWorkloads" DependsOnTargets="GetSuggestedWorkloads;PrepareProjectReferences" Returns="@(_ResolvedSuggestedWorkload)">
     <MSBuild
       Projects="@(_MSBuildProjectReferenceExistent)"
       Targets="_GetRequiredWorkloads"
       BuildInParallel="$(BuildInParallel)"
       Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''"
-      RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;TargetFrameworks">
+      RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)$(_GlobalPropertiesToRemoveFromProjectReferences);TargetFramework;TargetFrameworks"
+      SkipNonexistentTargets="true" >
       <Output TaskParameter="TargetOutputs" ItemName="SuggestedWorkloadFromReference"/>
     </MSBuild>
 

test/TestAssets/TestProjects/ProjectWithEsProjReference/App.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net9.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="./Lib.esproj" />
+  </ItemGroup>
+</Project>

test/TestAssets/TestProjects/ProjectWithEsProjReference/Lib.esproj

@@ -0,0 +1 @@
+<Project Sdk="Microsoft.VisualStudio.JavaScript.SDK/1.0.1948920" />

test/TestAssets/TestProjects/ProjectWithEsProjReference/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "lib",
+  "version": "1.0.0",
+  "description": "A test project to verify .NET SDK compatibility for workload restore and non-Managed projects",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "MIT"
+}

test/dotnet-workload-restore.Tests/GivenDotnetWorkloadRestore.cs

@@ -10,6 +10,7 @@ public GivenDotnetWorkloadRestore(ITestOutputHelper log) : base(log)
     }
 
     public static string DcProjAssetName = "SolutionWithAppAndDcProj";
+    public static string TransitiveReferenceNoWorkloadsAssetName = "ProjectWithEsProjReference";
 
     [Fact]
     public void ProjectsThatDoNotSupportWorkloadsAreNotInspected()
@@ -27,4 +28,21 @@ public void ProjectsThatDoNotSupportWorkloadsAreNotInspected()
         // if we did try to restore the dcproj in this TestAsset we would fail, so passing means we didn't!
         .Pass();
     }
+
+    [Fact]
+    public void ProjectsThatDoNotSupportWorkloadsAndAreTransitivelyReferencedDoNotBreakTheBuild()
+    {
+        var projectPath =
+            _testAssetsManager
+                .CopyTestAsset(TransitiveReferenceNoWorkloadsAssetName)
+                .WithSource()
+                .Path;
+
+        new DotnetWorkloadCommand(Log, "restore")
+        .WithWorkingDirectory(projectPath)
+        .Execute()
+        .Should()
+        // if we did try to restore the esproj in this TestAsset we would fail, so passing means we didn't!
+        .Pass();
+    }
 }