Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require individual languages opt-in to Hot Reload #19608

Closed
tmeschter opened this issue Aug 9, 2021 · 2 comments · Fixed by #19667
Closed

Require individual languages opt-in to Hot Reload #19608

tmeschter opened this issue Aug 9, 2021 · 2 comments · Fixed by #19667
Labels
untriaged Request triage from a team member

Comments

@tmeschter
Copy link
Contributor

Right now the SDK adds the "SupportsHotReload" project capability to every project targeting .NET 6.0 or above:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines 1129 to 1132 in e10860e

<!-- Enable hot reload in 6.0 and newer apps by default -->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' AND $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '6.0'))">
<ProjectCapability Include="SupportsHotReload" />
</ItemGroup>

This puts the burden on languages that do not currently support Hot Reload to know they need to opt out. It would be better to let each individual language opt-in to Hot Reload by adding this project capability in their individual .targets.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Aug 9, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@DamianEdwards
Copy link
Member

@pranavkm

pranavkm added a commit that referenced this issue Aug 11, 2021
@pranavkm
Require individual languages opt-in to Hot Reload
4e5d90e 
* Move capability to C# and VB project imports
* Add a feature switch to opt out of hot reload capability

Fixes #19608
@pranavkm pranavkm mentioned this issue Aug 11, 2021
Merged
pranavkm added a commit that referenced this issue Aug 11, 2021
@pranavkm
Require individual languages opt-in to Hot Reload (#19667)
f3f1d4d 
* Move capability to C# and VB project imports
* Add a feature switch to opt out of hot reload capability

Fixes #19608
@farlee2121 farlee2121 mentioned this issue Aug 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require individual languages opt-in to Hot Reload dotnet/sdk
2 participants
@DamianEdwards @tmeschter