Option to treat NETSDK warnings as errors

[nphmuller]

While updating to 2.2.100 I noticed a couple of warnings were added. Like NETSDK1071.
In my CI I build using the TreatWarningsAsErrors flag (dotnet build /p:TreatWarningsAsErrors="true")`.

The build still completed succesfully, while NETSDK1071 was thrown.

What is the recommended way to force a build to fail if any of these warnings are thrown from the SDK?
The most user friendly way would be to use the same flag as msbuild. But that doesn't seem to be supported atm.

[rainersigwald]

You can use the universal MSBuild flag with dotnet build /warnaserror. Confusingly, the TreatWarningsAsErrors is fairly specifically scoped down to compiler warnings (though other tasks have the option of opting in to it as well). That property was added before MSBuild added support for msbuild.exe /warnaserror.

[nphmuller]

Thanks for the quick response!

[Crono1981]

This still causes the build to exit with a success code when warnings occurs. :(

[nphmuller]

@Crono1981 Might be better to open a new issue for that. Would probably give you a proper response faster.

[Crono1981]

@nphmuller https://github.com/dotnet/core-sdk/issues/1708