Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated dependency via project reference and nuget leads to GenerateDepsFile crash #364

Closed
nguerrera opened this issue Nov 8, 2016 · 2 comments
Closed

Duplicated dependency via project reference and nuget leads to GenerateDepsFile crash #364

nguerrera opened this issue Nov 8, 2016 · 2 comments
Assignees
@mattwar
Labels
Bug
Milestone
1.0 RTM

Comments

@nguerrera
Copy link
Contributor

Repro steps

  • Have a PackageReference to Foo.nupkg
  • Also have a ProjectReference to Foo.csproj producing the same dll as nupkg

Expected behavior

  • Project reference wins and build succeeds

Actual behavior

  • Package reference wins for compilation input, GenerateDepsFile throws and aborts build.
@nguerrera nguerrera added this to the 1.0 RC2 milestone Nov 8, 2016
@nguerrera nguerrera self-assigned this Nov 8, 2016
@nguerrera nguerrera mentioned this issue Nov 9, 2016
Closed
@nguerrera nguerrera added the Bug label Nov 9, 2016
@nguerrera
Copy link
Contributor Author

Workaround:

  <Target Name="WorkAroundPackageAndProjectReferenceConflict" 
                BeforeTargets="ResolveLockFileReferences">
    <ItemGroup>
       <ResolvedCompileFileDefinitions 
           Remove="@(ResolvedCompileFileDefinitions)" 
           Condition="'%(ResolvedCompileFileDefinitions.Filename)' == 'Foo'" />
    </ItemGroup>
  </Target>

This was referenced Nov 20, 2016
Closed
Closed
@srivatsn srivatsn modified the milestones: 1.0 RC2, 1.0 RC3 Nov 29, 2016
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RTM Jan 11, 2017
@srivatsn srivatsn assigned mattwar and unassigned nguerrera Jan 31, 2017
@nguerrera nguerrera mentioned this issue Feb 1, 2017
Closed
@mattwar
Copy link

mattwar commented Feb 1, 2017

I'm not able to repro this crash in the current VS build d15rel 26129.0. It is actually working as expected. No exception, no crash.

@srivatsn srivatsn closed this as completed Feb 9, 2017
sbomer pushed a commit to sbomer/sdk that referenced this issue Sep 19, 2017
@ericstj
Merge pull request dotnet#364 from ericstj/removeMetadata
16676bd 
Remove NuGet metadata
mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@vijayrkn
Merge pull request dotnet#364 from aspnet/vramak/HandleWebJobsArguments
1ed3109 
Make the generated run.cmd file handle additional args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwar mattwar

Labels
Bug
Projects
None yet
Milestone
1.0 RTM
Development

No branches or pull requests
3 participants
@srivatsn @nguerrera @mattwar