Implement PreserveCompilationContext #112
Conversation
eerhardt
force-pushed
the
PreserveCompilationContext
branch
from
3e5886e to
1e256f3
Compare
eerhardt
force-pushed
the
PreserveCompilationContext
branch
from
1e256f3 to
e905acd
Compare
| { | ||
| // write the result file out on failure for easy comparison | ||
|
|
||
| using (JsonTextWriter writer = new JsonTextWriter(File.CreateText($"result-{baselineFileName}.deps.json"))) |
There was a problem hiding this comment.
Should this be dumped on the screen instead? Thinking about CI here? Or maybe, have it dumped on a file only for dev machines but always show it in the console?
There was a problem hiding this comment.
It is always shown in the console. The exception thrown by .Should().BeEquivalentTo() contains both the baseline and the result.
However that formatting is near un-readable because of https://github.com/dennisdoomen/FluentAssertions/issues/453. And also "diffing" between the two is impossible when the object is larger than a few properties.
In reply to: 77233060 [](ancestors = 77233060)
There was a problem hiding this comment.
All right, but do we care about this file being generated in CI like that? I wonder if this is a bad pattern to pick up.
There was a problem hiding this comment.
If we could capture the bin directory in CI, then yes. This would greatly help debugging failures of these tests.
|
LGTM, would like @pakrym to take a look at the deps files to make sure the syntax is right, but otherwise looks OK. |
|
LGTM |
| { | ||
| // TODO: What other information about the current project needs to be included here? - https://github.com/dotnet/sdk/issues/12 | ||
|
|
||
| RuntimeAssetGroup[] runtimeAssemblyGroups = new[] { new RuntimeAssetGroup(string.Empty, $"{projectName}.dll") }; |
There was a problem hiding this comment.
you are teasing me with this right.... Urgh... can't.... resits...
NIT: var.
|
|
eerhardt
force-pushed
the
PreserveCompilationContext
branch
2 times, most recently
from
b2b0c52 to
46f3f14
Compare
|
@dotnet-bot test this please |
eerhardt
force-pushed
the
PreserveCompilationContext
branch
from
46f3f14 to
a22eb92
Compare
Implement PreserveCompilationContext
Update netstandard to use open key
Implementing PreserveCompilationContext during publish.
See https://github.com/dotnet/cli/issues/3932 for how this feature works, and why.
There is one thing left to do: #111
@brthor @livarcocc @natidea @nguerrera
/cc @dotnet/project-system