[main] Update dependencies from dotnet/runtime #17948

dotnet-maestro · 2021-05-28T12:24:41Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20210531.1
Date Produced: 5/31/2021 8:55 AM
Commit: fea7ff2cce79da2df9cf1c50ce215287750f055e
Branch: refs/heads/main

Updates:
- Microsoft.NETCore.Platforms: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.NETCore.DotNetHostResolver: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.NET.HostModel: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.Extensions.DependencyModel: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.NETCore.App.Host.win-x64: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- Microsoft.NETCore.App.Ref: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- System.Reflection.MetadataLoadContext: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- System.Resources.Extensions: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- System.Security.Cryptography.ProtectedData: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- System.Text.Encoding.CodePages: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- System.CodeDom: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.6.21276.13 to 6.0.0-preview.6.21281.1

…0528.2 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21276.13 -> To Version 6.0.0-preview.6.21278.2

dotnet-issue-labeler · 2021-05-28T12:24:44Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-maestro · 2021-05-28T13:10:06Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

eerhardt · 2021-05-28T16:06:49Z

@adamsitnik - this looks like it is caused by dotnet/runtime#53231.

Two different legs are failing with:

Unhandled exception. System.TypeLoadException: Could not load type 'System.IO.Directory' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at Microsoft.NET.TestFramework.TestContext.Initialize(TestCommandLine commandLine)
   at Microsoft.NET.TestFramework.TestCommandLine.HandleCommandLine(String[] args) in /_/src/Tests/Microsoft.NET.TestFramework/TestCommandLine.cs:line 272
   at Program.Main(String[] args) in /_/src/Tests/Common/Program.cs:line 14

eerhardt · 2021-05-28T16:12:06Z

@sfoslund @dsplaisted @wli3 - is it possible that the tests are using 2 different versions of the runtime? Building against one and running against the older SDK?

dsplaisted · 2021-05-28T17:17:12Z

is it possible that the tests are using 2 different versions of the runtime? Building against one and running against the older SDK?

In this case, essentially yes. In our build we update the FrameworkReference to use the version coming from dependency flow instead of the one in stage 0:

sdk/Directory.Build.targets

Lines 38 to 46 in 3c50a7d

    
             <!-- Update KnownFrameworkReferences to target the right version of the runtime --> 
        
             <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' 
        
                                     and $(MicrosoftNETCoreAppRefPackageVersion.StartsWith('$(_TargetFrameworkVersionWithoutV)')) 
        
                                     and '$(MSBuildProjectName)' != 'toolset-tasks'"> 
        
               <FrameworkReference 
        
                   Update="Microsoft.NETCore.App" 
        
                   TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)" 
        
                   RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)" /> 
        
             </ItemGroup>

The test projects themselves run on stage 0, which doesn't include the latest runtime. Many of the tests create projects and then launch a separate process to build or run the project, and the separate project uses "stage 2" which is the just-built SDK which includes the latest runtime. However, it looks like these BrowserRefresh tests are running in-process.

If the BrowserRefresh tests are the only ones failing, we may need to disable them until we can flow the runtime update through and update stage 0. If there are other test projects impacted, then we may need to disable the FrameworkReference update until we can complete that loop.

eerhardt · 2021-05-28T17:22:47Z

This seems like it could be an issue any time we do refactoring in the runtime. Can the owner of these tests fix it so they don't build and run against different versions of the runtime?

dsplaisted · 2021-05-28T20:07:38Z

OK, I dug into the history a bit more, and it actually is supposed to be running the tests on the same updated runtime. Here's the original PR for reference: dotnet/cli#11639

The global.json specifies the same version that is used to compile against as a runtime, and the arcade tooling downloads that runtime and it gets used.

However, what appears to be going on here is that it's only downloading the Microsoft.NETCore.App shared framework. So when a test uses the ASP.NET Core shared framework in-process, it loads the stage 0 version of that shared framework, which loads the stage 0 version of Microsoft.NETCore.App, since that's the closest match to the version specified in Microsoft.AspNetCore.App.runtimeconfig.json.

Ideally it would roll-forward to the latest version of Microsoft.NETCore.App, but I'm not sure we have a way of doing that. Or maybe we should say that we shouldn't be testing other shared frameworks in-process in the tests.

Right now I'm inclined to disable the tests until the update flows.

Thoughts?

@captainsafia, @pranavkm, @mkArtakMSFT

pranavkm · 2021-05-28T20:49:22Z

Right now I'm inclined to disable the tests until the update flows.

That's a fine solution for now. I'll see if there's a way to move those tests out of this repo since we had some trouble with them earlier too.

dsplaisted · 2021-05-28T23:33:21Z

I think I have a fix for this, though I don't have enough time to finish it today. If the test lists both shared frameworks in its runtimeconfig file (which normally doesn't happen), then the test project will load the right version of Microsoft.NETCore.App.

Here's the proof of concept target I added to the BrowserRefresh tests:

  <Target Name="PatchRuntimeConfig" AfterTargets="GenerateBuildRuntimeConfigurationFiles">
    <PropertyGroup>
      <PatchedRuntimeConfigContents>
        <![CDATA[
{
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
    {
      "name": "Microsoft.NETCore.App",
      "version": "$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)"
    },
    {
      "name": "Microsoft.AspNetCore.App",
      "version": "6.0.0-preview.6.21277.6"
    }
    ],
    "rollForwardOnNoCandidateFx": 2
  }
}
]]>
      </PatchedRuntimeConfigContents>
    </PropertyGroup>

    <WriteLinesToFile File="$(ProjectRuntimeConfigFilePath)"
                      Lines="$(PatchedRuntimeConfigContents)"
                      Overwrite="true"/>
    
  </Target>

At a minimum it needs to be updated so that the version for Microsoft.AspNetCore.App is not hard-coded.

…0528.10 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21276.13 -> To Version 6.0.0-preview.6.21278.10

…0529.3 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21276.13 -> To Version 6.0.0-preview.6.21279.3

dsplaisted · 2021-05-30T21:49:11Z

I think this should be fixed with 7bb178a

…0531.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21276.13 -> To Version 6.0.0-preview.6.21281.1

….NETCore.App shared framework

eerhardt · 2021-06-01T15:18:19Z

src/Assets/TestPackages/dotnet-dependency-context-test/dotnet-dependency-context-test.csproj

@@ -8,7 +8,8 @@
  </PropertyGroup>

  <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="$(MicrosoftExtensionsDependencyModelPackageVersion)" />
+    <!-- .NET 6 versions of this package no longer support .NET Core 2.2, so hard-code the version here to 5.0 -->


I'm not sure what this means. The package supports netstandard2.0, why wouldn't that asset be used?

cc @ViktorHofer

It looks like the latest build of DependencyModel now depends on System.Runtime.CompilerServices.Unsafe, and that package has a target in it blocking the build:

<Project InitialTargets="NETStandardCompatError_System_Runtime_CompilerServices_Unsafe_netcoreapp3_1"> <Target Name="NETStandardCompatError_System_Runtime_CompilerServices_Unsafe_netcoreapp3_1" Condition="'$(SuppressTfmSupportBuildWarnings)' == ''"> <Error Text="System.Runtime.CompilerServices.Unsafe doesn't support $(TargetFramework). Consider updating your TargetFramework to netcoreapp3.1 or later." /> </Target> </Project>

OK, that explains it. Thanks.

You're the first one that encounters these recent changes. I plan to send out a breaking change notice later this week after I synced up with @terrajobst on the format.

Is there a reason for dotnet/sdk to still have tests that build against an unsupported version of .NETCoreApp?

@ViktorHofer Late reply: Generally we want the SDK to continue to build projects successfully even if they're out of support. IE when a runtime goes out of support it means it won't get updates anymore, not that suddenly the tools stop working for that runtime.

dotnet-maestro bot added 2 commits May 29, 2021 12:13

dsplaisted force-pushed the darc-main-355dc96c-6d24-406c-8a87-c981ebd7be22 branch 2 times, most recently from 6160b78 to 0cd40b6 Compare May 31, 2021 14:30

dsplaisted added 2 commits May 31, 2021 08:13

Fix issue where ASP.NET tests or tools could run on Stage 0 Microsoft…

150c6fa

….NETCore.App shared framework

Fix dependency context test

23ca01c

dsplaisted force-pushed the darc-main-355dc96c-6d24-406c-8a87-c981ebd7be22 branch from 0cd40b6 to 23ca01c Compare May 31, 2021 15:13

dotnet-maestro bot merged commit 1a1d48d into main May 31, 2021

dotnet-maestro bot deleted the darc-main-355dc96c-6d24-406c-8a87-c981ebd7be22 branch May 31, 2021 16:09

dsplaisted mentioned this pull request Jun 1, 2021

Don't omit Microsoft.NETCore.App from list of frameworks in runtimeconfig #17982

Merged

eerhardt reviewed Jun 1, 2021

View reviewed changes

dsplaisted mentioned this pull request Jun 18, 2021

Revert workaround for runtimeconfig generation issue #18372

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #17948

[main] Update dependencies from dotnet/runtime #17948

dotnet-maestro bot commented May 28, 2021 •

edited

Loading

dotnet-issue-labeler bot commented May 28, 2021

dotnet-maestro bot commented May 28, 2021

eerhardt commented May 28, 2021

eerhardt commented May 28, 2021

dsplaisted commented May 28, 2021

eerhardt commented May 28, 2021

dsplaisted commented May 28, 2021

pranavkm commented May 28, 2021

dsplaisted commented May 28, 2021

dsplaisted commented May 30, 2021

eerhardt Jun 1, 2021

dsplaisted Jun 1, 2021

eerhardt Jun 1, 2021

ViktorHofer Jun 1, 2021

dsplaisted Jun 18, 2021

[main] Update dependencies from dotnet/runtime #17948

[main] Update dependencies from dotnet/runtime #17948

Conversation

dotnet-maestro bot commented May 28, 2021 • edited Loading

From https://github.com/dotnet/runtime

dotnet-issue-labeler bot commented May 28, 2021

dotnet-maestro bot commented May 28, 2021

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

eerhardt commented May 28, 2021

eerhardt commented May 28, 2021

dsplaisted commented May 28, 2021

eerhardt commented May 28, 2021

dsplaisted commented May 28, 2021

pranavkm commented May 28, 2021

dsplaisted commented May 28, 2021

dsplaisted commented May 30, 2021

eerhardt Jun 1, 2021

Choose a reason for hiding this comment

dsplaisted Jun 1, 2021

Choose a reason for hiding this comment

eerhardt Jun 1, 2021

Choose a reason for hiding this comment

ViktorHofer Jun 1, 2021

Choose a reason for hiding this comment

dsplaisted Jun 18, 2021

Choose a reason for hiding this comment

dotnet-maestro bot commented May 28, 2021 •

edited

Loading