Change name to match spec #18590
Merged
Change name to match spec #18590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
approved these changes
Jun 28, 2021
|
Adding a DO NOT MERGE until #18555 is fixed. |
pgovind
force-pushed
the
preview_feature_followup
branch
from
a0d10e3
to
99b0efc
Compare
|
Build failure looks unrelated. Re-running CI just in case |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changing
GeneratePreviewFeaturesAttributetoGenerateRequiresPreviewFeaturesAttributeto match https://github.com/dotnet/designs/blob/main/accepted/2021/preview-features/preview-features.md#building-a-library-that-offers-preview-features. Also added a unit test. Should be a straightforward review