Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #18801

Merged
merged 2 commits into from
Jul 9, 2021
Merged

[main] Update dependencies from dotnet/runtime #18801

merged 2 commits into from
Jul 9, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 8, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20210709.1
  • Date Produced: 7/9/2021 10:20 AM
  • Commit: d431d6a15726797965336176efe9ae15aba241fd
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
5b3916e 
…0708.2

Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.7.21357.1 -> To Version 6.0.0-preview.7.21358.2
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jul 8, 2021

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@jeffschwMSFT
Copy link
Member

The current failures seem to be helix 201 response code issues on log upload.

2021-07-08T13:05:28.181Z INFO xunit-reporter.py event(51) send Sending event type File
2021-07-08T13:05:28.228Z INFO xunit-reporter.py saferequests(87) request_with_retry Response complete with status code '201'
2021-07-08T13:05:28.228Z INFO xunit-reporter.py event(51) send Sending event type XUnitTestResult
2021-07-08T13:05:28.290Z INFO xunit-reporter.py saferequests(87) request_with_retry Response complete with status code '201'

@jeffschwMSFT
Copy link
Member

@steveisok @vitek-karas the WebAssembly test is consistently failing. I found the following in the log.

    resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(4,8): warning IL2009: Could not find method 'System.Boolean IsGloballyEnabled()' on type 'System.Net.Http.DiagnosticsHandler' [C:\h\w\A7B008F1\t\dotnetSdkTests\msk4nsnr.lp1\Publish_Minim---C83C20DE\blazorwasm-minimal.csproj]

@steveisok
Copy link
Member

@steveisok @vitek-karas the WebAssembly test is consistently failing. I found the following in the log.

    resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(4,8): warning IL2009: Could not find method 'System.Boolean IsGloballyEnabled()' on type 'System.Net.Http.DiagnosticsHandler' [C:\h\w\A7B008F1\t\dotnetSdkTests\msk4nsnr.lp1\Publish_Minim---C83C20DE\blazorwasm-minimal.csproj]

Appears the latest commit to the Diagnostics handler changed IsGloballyEnabled to a field, but did not update the linker substitutions.

dotnet/runtime#54755

Shouldn't the builds catch this and fail?

@jeffschwMSFT
Copy link
Member

Adding @antonfirsov and @karelz. Can we get an update to unblock this dependency flow?

@steveisok
Copy link
Member

I started with dotnet/runtime#55351

@steveisok steveisok mentioned this pull request Jul 8, 2021
Merged
steveisok added a commit to dotnet/runtime that referenced this pull request Jul 9, 2021
@steveisok
Move DiagnosticsHandler.IsGloballyEnabled back to a method (#55351)
03cb946 
Intent is to make linker substitutions happy and try to unblock dotnet/sdk#18801
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
7da2e37 
…0709.1

Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.7.21357.1 -> To Version 6.0.0-preview.7.21359.1
@jeffschwMSFT
Copy link
Member

The failure looks transitory

C:\h\w\AA410959\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(259,5): error NETSDK1024: Folder 'C:\h\w\AA410959\t\dotnetSdkTests\m5gcxcyc.3mc\It_uses_star_---74E2FBB4\w' already exists either delete it or provide a different ComposeWorkingDir [C:\h\w\AA410959\t\dotnetSdkTests\m5gcxcyc.3mc\It_uses_star_---74E2FBB4\StarVersion.xml]

@jeffschwMSFT
Copy link
Member

Another transitory issue:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(131,5): error : A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond

@dotnet-maestro dotnet-maestro bot merged commit 3925ab7 into main Jul 9, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-e12c04a9-070b-4860-b409-a7af5b6ad643 branch July 9, 2021 17:41
v-wuzhai pushed a commit that referenced this pull request Apr 22, 2024
@ViktorHofer
Only msbuild code formatting (#18801)
5e23458
ViktorHofer added a commit that referenced this pull request May 7, 2024
@ViktorHofer
Only msbuild code formatting (#18801)
0db4751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-CodeFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffschwMSFT @steveisok @danmoseley