Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.1xx-rc2] Update dependencies from dotnet/roslyn #21287

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 22, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 21baa2a8-cb4a-4584-a324-08d978894a66
  • Build: 20210927.12
  • Date Produced: September 27, 2021 9:27:37 PM UTC
  • Commit: ea8b7316adb82d7b2ab9ab570d4ae100019f6a6e
  • Branch: refs/heads/main-vs-deps

…922.6

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21472.6
…922.9

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21472.9
…922.14

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21472.14
…922.17

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21472.17
…923.4

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21473.4
…923.9

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21473.9
…923.12

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21473.12
…923.17

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21473.17
…923.22

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21473.22
…924.1

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.1
…924.5

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.5
…924.9

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.9
…924.12

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.12
…924.18

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.18
…924.20

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21474.20
…925.2

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21475.2
…925.4

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21475.4
…926.2

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21476.2
@marcpopMSFT
Copy link
Member

@dotnet/roslyn-infrastructure Can someone take a look at the failure for It_resolves_analyzers_tareting_mulitple_roslyn_versions? It looks like it could just need a test update but since the PR is from Roslyn, I want someone from Roslyn investigating. #21285 has similar failures.

…927.2

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21477.2
…927.4

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21477.4
@jaredpar
Copy link
Member

I believe that the following PR from Roslyn should fix the test issue that we are seeing

dotnet/roslyn#56662

@RikkiGibson

@marcpopMSFT, @dsplaisted who owns the following test? We'd like to chat with them to better understand its purpose. It appears to be loading dependencies between analyzers here which is surprising to us. Want to know more about what scenarios inspired this test. Microsoft.DotNet.Cli.Build.Tests.GivenDotnetBuildBuildsCsproj.It_resolves_analyzers_tareting_mulitple_roslyn_version

…927.12

Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-5.21471.19 -> To Version 4.0.0-5.21477.12
@marcpopMSFT
Copy link
Member

@eerhardt added that test if you want to talk to him about it.

@eerhardt
Copy link
Member

who owns the following test? We'd like to chat with them to better understand its purpose. It appears to be loading dependencies between analyzers here which is surprising to us. Want to know more about what scenarios inspired this test.

This test was introduced in #20793 which implements Support multi-targeting for Roslyn components #20355. It tests the SDK's analyzer resolution logic on which analyzer to pick for a version of Roslyn.

It appears the change I made in dotnet/roslyn#56460 is conflicting with this test, and is always overriding the CompilerApiVersion value.

I can push up a fix for this in the test.

The latest Roslyn sets CompilerApiVersion which is overriding the values placed in the project in this test. Use a command line property instead to override Roslyn's targets file.
@dotnet-maestro dotnet-maestro bot merged commit 54cf978 into release/6.0.1xx-rc2 Sep 28, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0.1xx-rc2-da79b92f-5d6b-4f59-9499-24ec7ba8661d branch September 28, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants