Expand existing warning to target 5.0 #27942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marcpopMSFT
commented
Sep 19, 2022
| @@ -20,7 +20,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| receive servicing updates and security fixes. | |||
| --> | |||
| <ItemGroup> | |||
| <_EolNetCoreTargetFrameworkVersions Include="1.0;1.1;2.0;2.1;2.2;3.0" /> | |||
| <_EolNetCoreTargetFrameworkVersions Include="1.0;1.1;2.0;2.1;2.2;3.0;5.0" /> | |||
There was a problem hiding this comment.
Customers consider new warnings in existing products to be highly impactful. We included a 2.1 warning the month after it went out of support and got a lot of feedback. After discussion internally when 5.0 went out of support, we decided to delay turning on this warning for 6 months after 5.0 went out of support to align with our 7.0 release to give customers more time before we rolled out the warning. I expect 3.1 will also be delayed by a few months before we add that warning.
baronfel
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 5.0 runtime went out of support in May. At the time, we discussed when to add the warning message to customer builds when targeting 5.0. We decided it made sense to align that with the next major release so we're planning on doing this for the November releases: #27943
Customer Impact
Customer will get a build warning for any project that targets 5.0.
Regression
No
Risk
Low. Customers can add CheckEolTargetFramework=false to avoid this warning.
Testing
Automated