Resolve runtime pack assets #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
reviewed
Jan 15, 2019
src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
…deps.json for Linux
nguerrera
approved these changes
Jan 15, 2019
| assetInfo.DestinationSubPath = item.GetMetadata(MetadataKeys.DestinationSubPath); | ||
|
|
||
| string assetTypeString = item.GetMetadata(MetadataKeys.AssetType); | ||
| if (assetTypeString.Equals("runtime", StringComparison.OrdinalIgnoreCase)) |
src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs
Outdated
Show resolved
Hide resolved
… like an absolute path
|
@dsplaisted with dotnet/core-setup#4978 being fixed, the workaround to prefix paths in |
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
….10 (#2822) - Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19461.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/cli/issues/10096