Deps.json should include project references that aren't present in project.assets.json

[wrall]

Addresses #28891.

Although most projects are included in project.assets.json after a restore takes place, there are some (rare) scenarios when this is not the case. When that happens, project references end up being skipped and excluded from deps.json.

One can work around this by adding a binary Reference, that is inconvenient and can lead to issues when one forgets. Instead, it would be good to check whether the project reference is included in project.assets.json before skipping it when generating the list of dependencies.

Also added a functional test (.NET 6.0 project referencing a .NET Framework project) that failed previously and succeeds now.

(Continues #28892, retargeting release/7.0.2xx)

[wrall]

(@marcpopMSFT @dsplaisted FYI.)

[dsplaisted]

This is looking great, thanks!

[dsplaisted]

Under what conditions would this be null or empty, and should we be returning true here?

[dsplaisted]

Looks like there are some test failures in CI: GivenThatWeWantToPublishAProjectWithAllFeatures.It_fails_when_nobuild_is_set_and_build_was_not_performed_previously and GivenThatWeWantToPreserveCompilationContextForBuild.It_supports_copylocal_false_references. Let us know if you need help fixing those.

Thanks!

[wrall]

@dsplaisted said:

Looks like there are some test failures in CI: GivenThatWeWantToPublishAProjectWithAllFeatures.It_fails_when_nobuild_is_set_and_build_was_not_performed_previously and GivenThatWeWantToPreserveCompilationContextForBuild.It_supports_copylocal_false_references.

These should be fixed now - there was an issue with how I resolved some of the comments from the last PR.

[wrall]

FYI, latest update was to hide the new behavior behind a new MSBuild property. (Note that the test case I added fails without the new switch being provided, but I did not add a negative test).

[StephenBonikowsky]

@dsplaisted and @marcpopMSFT is this ready to be merged?