Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] ResolveReadyToRunCompilers: map non-portable rids when targetOS is determined. (#28380) #29052

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

tmds
Copy link
Member

@tmds tmds commented Nov 14, 2022

Backport #28380

Customer impact

Allows for flow of new RIDs that have yet to be added to runtime graph. This is important for distro maintainers as it is a maintainance headache to constantly have to manually update the runtime graph at every release.

Testing

  • unit tests in ci
  • source-build build within Alpine environment passes

Risk

Low, as it only activates when additional runtime RIDs are to be added

…termined. (dotnet#28380)

* ResolveReadyToRunCompilers: map non-portable rids when targetOS is determined.

* For source-build, allow using a rid that is not in the graph if it matches the host rid.
Copy link
Member

@AntonLapounov AntonLapounov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmds
Copy link
Member Author

tmds commented Nov 17, 2022

Can you merge this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants