Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0.2] add warning scrubber #29934

Merged
merged 1 commit into from
Jan 13, 2023
Merged

[release/7.0.2] add warning scrubber #29934

merged 1 commit into from
Jan 13, 2023

Conversation

YuliiaKovalova
Copy link
Member

Problem

The warning "Failed to evaluate bind symbol 'langVersion', it will be skipped." is generated sporadically.

Solution

Added scrubber excludes its presence in the output file.

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 13, 2023 14:16
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@YuliiaKovalova YuliiaKovalova added the Area-dotnet new the item is related to dotnet new command label Jan 13, 2023
JanKrivanek
JanKrivanek approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a workaround.
Please consider creating an issue for investigating and addressing nondeterminsitic behavior of the tests and link it here for reference

@YuliiaKovalova
Copy link
Member Author

Looks good as a workaround. Please consider creating an issue for investigating and addressing nondeterminsitic behavior of the tests and link it here for reference

done!
dotnet/templating#6781
Thank you

@YuliiaKovalova YuliiaKovalova changed the title add warning scrubber [release/7.0.2] add warning scrubber Jan 13, 2023
@YuliiaKovalova YuliiaKovalova merged commit 9acbc4d into dotnet:release/7.0.2xx Jan 13, 2023
@vlada-shubina
Copy link
Member

We need to investigate it deeply, as discussed - this should not be a case, and this workaround may actually hide a bug.
@YuliiaKovalova could you please create the issue for that? Thank you.

@YuliiaKovalova
Copy link
Member Author

We need to investigate it deeply, as discussed - this should not be a case, and this workaround may actually hide a bug. @YuliiaKovalova could you please create the issue for that? Thank you.

the issue was created
dotnet/templating#6781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Assignees
No one assigned
Labels
Area-dotnet new the item is related to dotnet new command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuliiaKovalova @vlada-shubina @JanKrivanek