Containers: add mappings for s390x and ppc64le platform architectures to corresponding rids. #33280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to corresponding rids.
dotnet-issue-labeler
bot
added
Area-Containers
|
Can you add this to #33166 and extend the tests that I added in that PR instead? I don't want to lose this and in that PR I extracted out the RID mapping to a separate component for reuse as a build task + easier testing. |
|
Also, it's cool as heck that you all have such a broad image baseline! |
Sure, I'll do that once that PR is merged. |
|
Closing in favor of #33166. |
MichalPavlik
approved these changes
Jun 21, 2023
|
@tmds yeah we're going to take this now because 8.0.100-p6 snap is today. Should auto-merge once green. Thanks again for adding this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rids for these architectures are defined in the rid graph, and Red Hat provides images for them, like ubi8/dotnet-70-runtime.
@baronfel ptal.