Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers: support mapping non-portable (source-built) rids to container manifest platforms. #33775

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

tmds
Copy link
Member

@tmds tmds commented Jul 4, 2023

Implements #33166 (comment)

@baronfel ptal.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Jul 4, 2023
@tmds tmds force-pushed the containers_rid_match branch from 857206a to b1b8f48 Compare July 4, 2023 19:35
@baronfel
Copy link
Member

baronfel commented Jul 7, 2023

Oh yeah, this is a lot cleaner. I looked at the code in NuGet.Frameworks as well that's implementing ExpandRuntimes and it's exactly what I thought it would be - iteratively walking the RID graph for runtimes that match.

@baronfel baronfel merged commit ea7fc02 into dotnet:main Jul 7, 2023
@baronfel baronfel removed the untriaged Request triage from a team member label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants