Update RID parsing's LastIndexOf call to use invariant culture
#35637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
LastIndexOf('-') with a char literal would be a bit more correct, by ensuring that the length of the matched substring is exactly one char. |
JL03-Yue
force-pushed
the
rid-parsing-not-consider-culture
branch
from
e257e78 to
85e28f7
Compare
dsplaisted
approved these changes
Sep 25, 2023
JL03-Yue
requested review from
a team,
andriipatsula,
ericstj,
joperezr,
tmat,
arunchndr,
AntonLapounov,
sharwell and
vijayrkn
as code owners
JL03-Yue
removed request for
a team,
tmat,
sharwell,
vijayrkn,
ericstj,
joperezr,
andriipatsula,
AntonLapounov and
arunchndr
…mmand; Add tests for rid parsing
JL03-Yue
force-pushed
the
rid-parsing-not-consider-culture
branch
from
5645069 to
8c76bcb
Compare
MiYanni
reviewed
Sep 25, 2023
There was a problem hiding this comment.
General question: Is there a reason to use static methods for parsing the RID instead of just having a RID class that does a Split once and saves the parts as properties? My thought is that having static methods encourages reparsing (which we wouldn't want) whereas a RID class encourages passing around an instance of itself for use where the info is needed.
CC @dsplaisted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #34347, update RID parsing's
LastIndexOfcall to use invariant culture