Disable Source Link's EmbedUntrackedSources in desktop WPF projects #37164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
baronfel
reviewed
Nov 28, 2023
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props
Outdated
Show resolved
Hide resolved
|
@KirillOsenkov FYI |
tmat
added
Servicing-consider
and removed
untriaged
dsplaisted
approved these changes
Nov 29, 2023
tmat
changed the title
rainersigwald
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workaround for #34438:
Suppress EmbedUntrackedSources set by Source Link for Desktop WPF projects, which produce incorrect
#linedirective in generated .g.cs files under certain circumstances. When EmbedUntrackedSources is enabled it triggers embedding of source files into the PDB, which fails due to the incorrect#linedirectives.#36585 tracks the core issue.
Customer Impact
Project with the following properties fails to build with .NET SDK 8:
UseWPFproperty totrueIntermediateOutputPathRegression?
7.0
Risk
The change sets property that enables the same code path that's already executed in regular build to run in design-time build.
Verification
Packaging changes reviewed?