Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable package aliasing tests #39144

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Disable package aliasing tests #39144

merged 3 commits into from
Mar 4, 2024

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Mar 1, 2024

The tests in GivenThatWeHaveAPackageReferenceWithAliases have started failing somewhat consistently in CI. I haven't been able to reproduce the issue locally. The failures look something like this:

/private/tmp/helix/working/B27409DB/w/A434093A/e/testExecutionDirectory/CanBuildProje---B79B2BCA/Project/Project.cs(9,13): error CS0118: 'First.A' is a namespace but is used like a type [/private/tmp/helix/working/B27409DB/w/A434093A/e/testExecutionDirectory/CanBuildProje---B79B2BCA/Project/Project.csproj]
/private/tmp/helix/working/B27409DB/w/A434093A/e/testExecutionDirectory/CanBuildProje---B79B2BCA/Project/Project.cs(10,20): error CS0234: The type or namespace name 'B' does not exist in the namespace '<global namespace>' (are you missing an assembly reference?) [/private/tmp/helix/working/B27409DB/w/A434093A/e/testExecutionDirectory/CanBuildProje---B79B2BCA/Project/Project.csproj]

This seems like it's probably a test issue, perhaps related to the fact that these tests create and then consume NuGet packages within the test. Because of this, I am going to disable these tests for now. To further investigate, we probably need to figure out how to get a binlog of the failures in Helix.

Attempting to fix CI failures for these tests
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 1, 2024
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should we merge this to unblock all the other PRs?

@dsplaisted
Copy link
Member Author

@baronfel I don't think the changes I had here actually fixed the tests, they failed in CI, and then I pushed a change to try to gather the binlogs to investigate further, and the tests passed. I think that was just coincidental, so I am now going to just disable these tests: #39172

@dsplaisted dsplaisted changed the title Use unique names for aliasing test packages Disable package aliasing tests Mar 4, 2024
@dsplaisted dsplaisted merged commit 5856ff3 into main Mar 4, 2024
16 checks passed
@dsplaisted dsplaisted deleted the update-alias-tests branch March 4, 2024 17:02
@dsplaisted
Copy link
Member Author

/backport to release/8.0.3xx

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/8145805473

@dsplaisted
Copy link
Member Author

/backport to release/9.0.1xx-preview2

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Started backporting to release/9.0.1xx-preview2: https://github.com/dotnet/sdk/actions/runs/8149693709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants