Trim trailing .git from sourcelink repo urls in container generation

[baronfel]

Fixes dotnet/sdk-container-builds#540 by trimming .git from sourcelink-derived repo urls

[KalleOlaviNiemitalo]

Trimming the trailing .git looks OK for GitHub but I suspect it can cause git clone to fail with other Git hosting software.

[baronfel]

We're not really worried about git clone here though?

[KalleOlaviNiemitalo]

At https://github.com/opencontainers/image-spec/blob/main/annotations.md, it's specified as

org.opencontainers.image.source URL to get source code for building the image (string)

If the value cannot be used for obtaining the source because .git is missing, then I think it violates this spec.

I'm thinking about on-premises Bitbucket in particular, which uses different URL paths for web browser HTML access and for Git access. But I don't remember whether it has .git in the latter.

[KalleOlaviNiemitalo]

Re on-premises Bitbucket, the HTTPS URL formats are like this (including the difference in letter case):

• https://server.example/projects/DOTNET/repos/sdk/browse for web browsers
• https://server.example/scm/dotnet/sdk.git for Git

Actually, it works even if you remove .git. The server does not reply with an HTTP redirection to add .git; it just aliases the path. So the trimming seems to be OK for on-premises Bitbucket too. How about others?

[baronfel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ladipro]

Since there seems to be some controversy about always considering the .git prefix trimmable, do you think it would be worth adding an opt-out property?

[baronfel]

Since there seems to be some controversy about always considering the .git prefix trimmable, do you think it would be worth adding an opt-out property?

Not really, no - this seems pretty self-evident for git repo server configuration, and users have a pretty clear workaround if that's the case. We can always revisit if it becomes a problem for folks.