Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RIDS in CompareMsftToSbAssemblyVersions test #42022

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jul 8, 2024

Closes dotnet/source-build#4493

When testing the changes in #41929, the CompareMsftToSbAssemblyVersions was continuing to fail with the following error message:

Unable to find matching file for 'packs/runtime.centos.9-x64.Microsoft.DotNet.ILCompiler/x.y.z/sdk/System.Private.StackTraceMetadata.dll' in '/tmp/t3vand3s.y0t/msft'

This file should fall under the following exclusion that exists in the exclusions file: ./packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/|sb. Upon investigation, I discovered that the issue was that unlike the CompareMsftToSbFileList test, the CompareMsftToSbAssemblyVersions test does not remove the RID from the file.

The fix here was to 1) Remove the RID from the SB file, and 2) replace the placeholder rids with matching patterns when attempting to file match to the Msft SDK.

We should merge this before merging in #41929

@ellahathaway ellahathaway requested review from a team as code owners July 8, 2024 17:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jul 8, 2024
@ellahathaway
Copy link
Member Author

@dotnet/source-build-internal - the failures are unrelated to these changes. Can someone please bypass the checks for this PR? These changes are necessary for a green SDK diff pipeline run. TIA

@ellahathaway ellahathaway enabled auto-merge (squash) July 8, 2024 23:21
@ellahathaway ellahathaway merged commit 09935d7 into dotnet:main Jul 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Main] All SDK Diff Tests Failing
2 participants