Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected exit code for mono in source-build smoke tests #42209

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Jul 17, 2024

The mono issue that caused the different exit code was fixed in dotnet/runtime#100056.

We now have the same exit code as coreclr so remove the mono special case.

Fixes dotnet/source-build#3174
Fixes dotnet/source-build#4514

The mono issue that caused the different exit code was fixed in dotnet/runtime#100056.

We now have the same exit code as coreclr so remove the mono special case.

Fixes dotnet/source-build#3174
Fixes dotnet/source-build#4514
@akoeplinger akoeplinger requested a review from mthalman July 17, 2024 09:29
@akoeplinger akoeplinger requested review from a team as code owners July 17, 2024 09:29
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jul 17, 2024
@akoeplinger akoeplinger enabled auto-merge (squash) July 17, 2024 10:28
@akoeplinger akoeplinger merged commit fb2c043 into main Jul 17, 2024
37 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch July 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
2 participants