Set props & envs to diagnose null ref issue #42320
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| @@ -84,6 +84,8 @@ | |||
| <!-- Pass locations for assets --> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetsDir=$(ArtifactsAssetsDir)</BuildArgs> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs> | |||
| <!-- TODO: Needed to debug null ref issue. Remove once https://github.com/dotnet/dnceng/issues/3305 is resolved --> | |||
| <BuildArgs>$(BuildArgs) /p:Features=debug-analyzers</BuildArgs> | |||
There was a problem hiding this comment.
Is this going to flow everywhere are needed or should this be set as an env?
There was a problem hiding this comment.
This flows all the way into the inner builds.
There was a problem hiding this comment.
Unfortunately /p: in MSBuild is a global final setting. So this would override anyone that is using <Features> in their project / props files. That is mostly esoteric copmiler flags so unlikley it's being used actively right now. For the moment think we should go forward with this as is to track down this problem.
@baronfel, @rainersigwald another case where a version of -p: which was initial value not final value would be useful.
| @@ -84,6 +84,8 @@ | |||
| <!-- Pass locations for assets --> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetsDir=$(ArtifactsAssetsDir)</BuildArgs> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs> | |||
| <!-- TODO: Needed to debug null ref issue. Remove once https://github.com/dotnet/dnceng/issues/3305 is resolved --> | |||
| <BuildArgs>$(BuildArgs) /p:Features=debug-analyzers</BuildArgs> | |||
There was a problem hiding this comment.
Unfortunately /p: in MSBuild is a global final setting. So this would override anyone that is using <Features> in their project / props files. That is mostly esoteric copmiler flags so unlikley it's being used actively right now. For the moment think we should go forward with this as is to track down this problem.
@baronfel, @rainersigwald another case where a version of -p: which was initial value not final value would be useful.
|
Build failures in fsharp are related to the envs. I’m currently investigating. |
Pull request was converted to draft
|
Going to trigger the builds on an internal branch instead of merging these changes into main. I'm keeping the PR open until we can finish investigating the build failures that occurred with these changes. |
|
Closing this PR since we found another way to repro. |
Related to dotnet/dnceng#3305
This PR sets the
Featuresprop todebug-analyzersand 3 envs to help debug the null ref issue linked above.The dumps will be published as build artifacts as part of
sdk/eng/pipelines/templates/jobs/vmr-build.yml
Line 471 in 2cc1c05