-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove longstanding comment from C# console template #42497
Open
baronfel
wants to merge
5
commits into
main
Choose a base branch
from
remove-comment-from-console-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfce2bc
Update Program.cs
baronfel 23d81ef
Merge branch 'main' into remove-comment-from-console-template
baronfel 9a1df5a
Remove more template expectations
baronfel 0876982
fix more tests
baronfel a711f17
Merge branch 'main' into remove-comment-from-console-template
baronfel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
src/Containers/packaging/build/Microsoft.NET.Build.Containers.buildschema.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"properties": { | ||
"EnableSdkContainerSupport": { | ||
"type": "bool", | ||
"defaultValue": "false", | ||
"description": "Enables the ability to package a project in a container. This is enabled by default if the project is an ASP.NET project or a Worker Project, or if the project includes a references to the Microsoft.NET.Build.Containers package." | ||
}, | ||
"ContainerBaseImage": { | ||
"type": "string", | ||
"defaultValue": "mcr.microsoft.com/dotnet/runtime:8.0", | ||
"description": "The base image to build the application container onto. If not specified the SDK will infer the best base image for your application.", | ||
"helpUrl": "https://github.com/dotnet/sdk-container-builds/blob/main/docs/ContainerCustomization.md#containerbaseimage" | ||
} | ||
} | ||
} |
5 changes: 1 addition & 4 deletions
5
...Microsoft.DotNet.Common.ProjectTemplates.9.0/content/ConsoleApplication-CSharp/Program.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
test/dotnet-new.Tests/Approvals/AotVariants.console.cs.verified/MyProject/Program.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
// See https://aka.ms/new-console-template for more information | ||
Console.WriteLine("Hello, World!"); | ||
Console.WriteLine("Hello, World!"); |
3 changes: 1 addition & 2 deletions
3
test/dotnet-new.Tests/Approvals/AotVariants.console.vb.verified/MyProject/Program.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
// See https://aka.ms/new-console-template for more information | ||
Console.WriteLine("Hello, World!"); | ||
Console.WriteLine("Hello, World!"); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0 intentional since this is main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that file shouldn't even be checked in, it's not relevant to this template change at all. Let me revert it.