-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResolvePackageReferences: PackageDependenciesDesignTime inherits transitive package DiagnosticLevel #42546
Conversation
…sitive package DiagnosticLevel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good for the most part, but I do have one question/concern for the code. PTAL and let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good to me, thank you :)
Triage: @zivkan you are clear to merge whenever but please file an issue and assign to yourself to do the follow up PR that you outlined. |
/backport to release/9.0.1xx |
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10745630791 |
The scenario is described here: NuGet/Home#13636
TL;DR in Visual Studio, Solution Explorer's dependencies node should put a warning icon on all the "parent" packages when a transitive package has a warning. While the transitive package icon overlays happens within NuGet's VS code the dotnet/project-system handles the top level package references, via ResolvePackageAssets output items.