Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Branding #42743

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Alpha Branding #42743

merged 10 commits into from
Aug 27, 2024

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 14, 2024
@marcpopMSFT
Copy link
Member Author

@baronfel There is a container endtoend test failing
/datadisks/disk1/work/957B07E0/p/d/sdk/10.0.100-ci/Containers/build/Microsoft.NET.Build.Containers.targets(241,5): error CONTAINER1015: Unable to access the repository 'dotnet/runtime' at tag '9.0' in the registry 'mcr.microsoft.com'. Please confirm that this name and tag are present in the registry.

@baronfel
Copy link
Member

I'd disable it for now - we are at a chicken and egg moment. The docker team won't have 9.0 images available until RC1 actually releases, at which point we can reenable the test

@marcpopMSFT
Copy link
Member Author

@tmat @mkArtakMSFT @dotnet/roslyn-ide there are a few watch test failures. Note that this is the initial net10.0 branding so some tests may be particularly sensitive to that.

Assert.StartsWith() Failure: String start does not match
String: null
Expected start: "Changed!"

Assert.StartsWith() Failure: String start does not match
String: null
Expected start: "Updated types: Printer"

Microsoft.CodeAnalysis.MSBuild.RemoteInvocationException : An exception of type System.InvalidOperationException was thrown: We don't have an MSBuild to use; HasUsableMSBuild should have been called first to check. - file BuildHost.cs line 133

@marcpopMSFT
Copy link
Member Author

@v-wuzhai would you be able to disable all of the failing tests in this PR and create an issue to track reenabling them? Since this is the start of the net10 work, I think it's ok to disable things temporarily to get unblocked.

@marcpopMSFT
Copy link
Member Author

@dotnet/product-construction this is trying to update branding for sdk to 10 and is the first step among many we'll have to do before main is ready for net10:
https://github.com/dotnet/sdk/blob/main/documentation/general/UpdateToNewTargetFramework.md

Can we disable unified build in main for now as the failures look like it wasn't there to be a net10 build? What should the process for this be?

@mmitche mmitche requested review from a team as code owners August 21, 2024 23:30
@marcpopMSFT
Copy link
Member Author

@dotnet/source-build-internal looks like the source build leg is now failing. Any ideas? This is the first step to enabling net10 support (which is really just having a 10 branding version of the SDK).

System.InvalidOperationException : Failed to execute /vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/extracted-sdk/dotnet format /vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/projects-202408220754550270/FormatProject/FormatProject.csproj
Exit code: 3
Unable to locate MSBuild. Ensure the .NET SDK was installed with the official installer.

@ellahathaway
Copy link
Member

ellahathaway commented Aug 22, 2024

@dotnet/source-build-internal looks like the source build leg is now failing. Any ideas? This is the first step to enabling net10 support (which is really just having a 10 branding version of the SDK).

System.InvalidOperationException : Failed to execute /vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/extracted-sdk/dotnet format /vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/projects-202408220754550270/FormatProject/FormatProject.csproj
Exit code: 3
Unable to locate MSBuild. Ensure the .NET SDK was installed with the official installer.

Looking - seems like the same issues as dotnet/source-build#3004. This could have something to do with how the MSBuildLocator is used in format.

I tested this with the UB artifacts and was able to repro this error, so this is not a source-build specific issue.

Maybe @dotnet/product-construction has ideas on what the issue could be?

@marcpopMSFT marcpopMSFT enabled auto-merge August 26, 2024 22:43
@marcpopMSFT marcpopMSFT merged commit 813d50e into main Aug 27, 2024
37 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-alphabranding branch August 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants