-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha Branding #42743
Alpha Branding #42743
Conversation
@baronfel There is a container endtoend test failing |
I'd disable it for now - we are at a chicken and egg moment. The docker team won't have 9.0 images available until RC1 actually releases, at which point we can reenable the test |
@tmat @mkArtakMSFT @dotnet/roslyn-ide there are a few watch test failures. Note that this is the initial net10.0 branding so some tests may be particularly sensitive to that. Assert.StartsWith() Failure: String start does not match Assert.StartsWith() Failure: String start does not match Microsoft.CodeAnalysis.MSBuild.RemoteInvocationException : An exception of type System.InvalidOperationException was thrown: We don't have an MSBuild to use; HasUsableMSBuild should have been called first to check. - file BuildHost.cs line 133 |
@v-wuzhai would you be able to disable all of the failing tests in this PR and create an issue to track reenabling them? Since this is the start of the net10 work, I think it's ok to disable things temporarily to get unblocked. |
@dotnet/product-construction this is trying to update branding for sdk to 10 and is the first step among many we'll have to do before main is ready for net10: Can we disable unified build in main for now as the failures look like it wasn't there to be a net10 build? What should the process for this be? |
@dotnet/source-build-internal looks like the source build leg is now failing. Any ideas? This is the first step to enabling net10 support (which is really just having a 10 branding version of the SDK).
|
Looking - seems like the same issues as dotnet/source-build#3004. This could have something to do with how the MSBuildLocator is used in format. I tested this with the UB artifacts and was able to repro this error, so this is not a source-build specific issue. Maybe @dotnet/product-construction has ideas on what the issue could be? |
No description provided.