-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0.1xx] Update dependencies from dotnet/runtime #42833
[release/9.0.1xx] Update dependencies from dotnet/runtime #42833
Conversation
…0819.2 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.1.24414.5 -> To Version 9.0.0-rc.1.24419.2 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-rc.1.24402.2 -> To Version 9.0.0-rc.1.24414.8 (parent: Microsoft.NETCore.App.Runtime.win-x64
Notification for subscribed users from https://github.com/dotnet/runtime:@dotnet/dnr-codeflow Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
rerunning due to native aot test failure |
@agocke can you take a look at this sdk Native AOT test failure? |
…c-42b4-97ba-6df375b5791a
|
interesting that rc1 runtime flow does not have the same problem |
…0820.15 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.1.24419.2 -> To Version 9.0.0-rc.2.24420.15 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-rc.1.24414.8 -> To Version 9.0.0-rc.1.24416.2 (parent: Microsoft.NETCore.App.Runtime.win-x64
Huh, the latest commit fix the problem. Now it's just wasm/blazor failures. @MichalStrehovsky Have you seen the above linker error before? Is this a failure case we should worry about? |
@lewing thoughts on this blazor failure?
|
The test can never work in release branches since we have to use unreleased downlevel version, if the blazor team wants to test downlevel in main we can set a property on the pipeline to change the targetframework in release. |
@javiercn thoughts on Larry's question about these tests working in release branches? |
@jeffschwMSFT I plan to revisit some of these tests next week. The changes @lewing to update the TFM, etc. are fine. Not 100% clear about the tests not working in release branches, as far as I know the branch shouldn't matter, but I'll follow up with him. |
…0821.12 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.2.24420.15 -> To Version 9.0.0-rc.2.24421.12 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-rc.1.24416.2 -> To Version 9.0.0-rc.1.24420.5 (parent: Microsoft.NETCore.App.Runtime.win-x64
@lewing can you take a look at this failure?
|
@dotnet/source-build-internal please take a look |
This is because of the downlevel versioning issue with workloads and the SDK, in release branch flow we have to reference unreleased versions of 8.0.x and 6.0.x when building runtime so to testing net8.0 targets that run workload resolution logic in a release branch requires either subscribing to stable package flow in downlevel versions or changes to workload construction/resolution. It is not something that can be fixed through authoring no matter how much I would like it to be |
yes, since everything for that version is in the dotnet9 feeds.
a net9 release branch can't branch can't build a net8 wasm/mobile target without a feed that has a downlevel version that matches so if you are using nuget.org it won't work until release day. rc1 requires 8.0.9, p7 required 8.0.8 etc. In runtime we keep main pointing at already released versions so 8.0.8 right now. That is why I qualified the statement with |
SB prebuilts are coming from dotnet/runtime#106743 that got backported to 9.0 (dotnet/runtime@c4a7987). Looking at that PR, it doesn't look like the SB leg ever ran. @lewing - out of curiosity, do you know why that is? Edit: Ah nevermind - I see now that the leg ran on the inner loop instead. |
@lewing thanks for the clarification. Let's chat about this on our next sync so that we can make sure we follow a similar approach to the one you folks have on the runtime repo. |
That flow was odd because there were two builds with the same sha (for complicated reasons) could that be confusing the logic? |
If it is related to that, there is a new build that should flow shortly and resolve the problem |
That could be it. I'm looking at the logs, and they're not telling me much, so it's possible that maybe the two builds have messed with the logic? It's hard to tell.
Yeah - I'd like if the prebuilts persist in the new flow or not. Let's wait for the new build to flow in and go from there. |
…0822.3 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.2.24421.12 -> To Version 9.0.0-rc.2.24422.3
ok, lets see how it goes |
…c-42b4-97ba-6df375b5791a
…0822.6 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.2.24422.3 -> To Version 9.0.0-rc.2.24422.6 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-rc.1.24420.5 -> To Version 9.0.0-rc.2.24421.3 (parent: Microsoft.NETCore.App.Runtime.win-x64
that was too old |
Looks like that was it |
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/runtime