Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net10.0 known framework references #42969

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

v-wuzhai
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 23, 2024
@v-wuzhai v-wuzhai marked this pull request as ready for review August 23, 2024 08:30
@v-wuzhai
Copy link
Member Author

@dotnet/source-build-internal Could you take a look at the failures here?

 Failed Microsoft.DotNet.SourceBuild.SmokeTests.WebScenarioTests.VerifyScenario(scenario: TestScenario { Commands = PublishSelfContained, Language = CSharp, NoHttps = False, ScenarioName = "WebScenarioTests", Template = WebApp, ··· }) [9 s]
  Error Message:
   Runtime packs were retrieved from NuGet instead of the SDK
  Stack Trace:
     at Microsoft.DotNet.SourceBuild.SmokeTests.WebScenarioTests.VerifyRuntimePacksForSelfContained(String projectPath) in /vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/WebScenarioTests.cs:line 55
   at Microsoft.DotNet.SourceBuild.SmokeTests.TestScenario.Execute(DotNetHelper dotNetHelper) in /vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/TestScenario.cs:line 75
   at Microsoft.DotNet.SourceBuild.SmokeTests.WebScenarioTests.VerifyScenario(TestScenario scenario) in /vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/WebScenarioTests.cs:line 25
   at InvokeStub_WebScenarioTests.VerifyScenario(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@ellahathaway
Copy link
Member

Looking - this test verifies that the runtime packs are not being pulled from NuGet. When they are, they end up in the cache and the test fails. Based on this, dotnet publish --self-contained is using NuGet to pull the runtime packs instead of the sdk.

Based on, dotnet/installer#16499 I think that @tmds may be the one who introduced some of the functionality into source-build that this test verifies. I also see dotnet/source-build#1215 as a related issue.

@MichaelSimons @tmds - do either of you have thoughts on what may be causing this test to fail?

@MichaelSimons
Copy link
Member

I think this test is going to need to be disabled through the net10.0 transition period. A new issue should be opened to track the re-enablement.

@tmds
Copy link
Member

tmds commented Aug 26, 2024

Runtime packs were retrieved from NuGet instead of the SDK

The error indicates that the SDK isn't finding a runtime pack that should be produced by the build. I don't know why this would stop working during bringup. I'm ok with disabling the test for some time, and perhaps it will resolve itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants