Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the sdk target to net10.0 #43015
Update the sdk target to net10.0 #43015
Changes from 4 commits
8480f31
10d8ad6
6003d81
ba19dd8
d69e52c
eb0cd8a
c4d1281
7d18b09
62d7486
58ce796
27881c4
7c671f9
83b8fdc
b18d98f
b715ece
d40538b
a951a65
742a88d
bd1d57a
9ae75b6
b676bbb
505ea26
3133bcf
6a07932
e6c3248
252429d
7f1ec30
284e14c
9c9f903
1bd7bd2
95f5fa9
50b52b1
2833c53
d99e5d0
24c81d3
5298648
89790ca
556992a
309f381
73fa346
8f1f484
a41669d
7909f2d
98bd6dd
8091644
f61431e
7cdb0cb
7933a2c
ff69d51
bdd67a2
6f4353a
4c08007
4693dfd
5c810ad
e64a7b3
012bedb
6441219
7bc9f92
18659d8
27a0734
d6ad34d
4aa59bd
5456196
bfa607a
8f28cbc
6d2c4eb
7a3c6e7
482ad03
c0cdf43
575036c
3820c21
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the build error message when set to net10.0.
C:\Users\AzureTest\Desktop\109\sdk\.dotnet\sdk\10.0.100-alpha.1.24507.21\Microsoft.Common.CurrentVersion.targets(1889,5): error NU1702: ProjectReference 'C:\Users\AzureTest\Desktop\109\sdk\test\Microsoft.NET.TestFramework\Microsoft.NET.TestFramework.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v9.0'. This project may not be fully compatible with your project. C:\Users\AzureTest\Desktop\109\sdk\.dotnet\sdk\10.0.100-alpha.1.24507.21\Microsoft.Common.CurrentVersion.targets(1889,5): error NU1702: ProjectReference 'C:\Users\AzureTest\Desktop\109\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v9.0'. This project may not be fully compatible with your project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What build did that trigger in? I tried locally and targeting net10.0 worked. The current builds are failing because the test framework isn't building because it doesn't have a net10.0 target (but projects that depend on it do have that). That means the nuget.config for the test projects never gets created. I pushed a change to switch back to net10.0 so we can see where this failure comes from.