-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support publishing of multi-architecture OCI container images #43085
Open
surayya-MS
wants to merge
106
commits into
dotnet:release/8.0.4xx
Choose a base branch
from
surayya-MS:multi-arch-containers
base: release/8.0.4xx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support publishing of multi-architecture OCI container images #43085
surayya-MS
wants to merge
106
commits into
dotnet:release/8.0.4xx
from
surayya-MS:multi-arch-containers
+1,893
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Containers
Related to dotnet SDK containers functionality
untriaged
Request triage from a team member
labels
Aug 29, 2024
3 tasks
A few notes that we will need to handle based on my trials at baronfel/sdk-container-demo#15
|
Or |
This reverts commit c2a29c4.
|
baronfel
changed the title
[DO NOT MERGE] Multi arch containers
Support publishing of multi-architecture OCI container images
Nov 11, 2024
This reverts commit ece7ee2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR:
PublishContainer
target renamed to_PublishSingleContainer
_PublishMultiArchContainers
target that calls_PublishSingleContainer
for each arch and then creates image indexPublishContainer
target calls either_PublishSingleContainer
or_PublishMultiArchContainers
depending on a conditionCreateImageIndex
that creates the image index (manifest list it's same thing) and pushes to the remote registry.Notes:
docker
in order to create manifest list (image index) the images must be available in the remote registry. Forpodman
it is possible to do it locally. That is not part of these PR. It will be the next iteration.Testing:
Tested manually for docker hub registry, linux-x64 and linux-arm64 architectures