Search version in set #43096
Search version in set #43096
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
So we've already added dotnet workload search version which lists the available workload set versions, right? It looks like this adds dotnet workload search version <workloadSetVersion>, and when the workload set version is specified it displays the manifests versions in that workload set.
I'm not sure about the scenario here. We do want to make more information available about what is in a workload set, but I think the manifest versions aren't too generally helpful here. Adding this now with this output format will make it harder to add more useful information (such as release notes, versions of tools such as XCode required, etc) to this command later.
| <value>SEARCH_STRING</value> | ||
| </data> | ||
| <data name="WorkloadVersionArgumentDescription" xml:space="preserve"> | ||
| <value>Output workload versions associated with the provided workload version.</value> |
There was a problem hiding this comment.
| <value>Output workload versions associated with the provided workload version.</value> | |
| <value>Output workload manifest versions associated with the provided workload version.</value> |
| if (_workloadSetOutputFormat?.Equals("json", StringComparison.OrdinalIgnoreCase) == true) | ||
| { | ||
| Reporter.WriteLine(JsonSerializer.Serialize( | ||
| workloadSet.ManifestVersions.ToDictionary(kvp => kvp.Key.ToString(), kvp => $"{kvp.Value.Version}/{kvp.Value.FeatureBand}"))); |
There was a problem hiding this comment.
I think this is (and should be) the same format as the rollback file. So use WorkloadSet.ToJson here instead of duplicating the logic of how it's formatted.
|
Triage: Summary is that the json format should have slightly more formatting so if we change this to add more data in the future, that is not a breaking change (ie put the manifest info in a subnode). |
- Generate error if workload search term and version subcommand are specified - If no workload sets are found, do not treat as an error, but print message to StdErr - Fix issue handling preview workload set versions when searching
Also split feature band out into separate column
|
I've made some updates to this and would appreciate a quick review. I added column headers to the table output and split the manifest feature band into a separate column. I've updated the PR description to show this. @baronfel, does this look good? |
|
Lovely! Thank you for updating the description. Totally agree with making the table output more user-friendly - with the json as the escape hatch we can freely change the user-facing views. |
Progress on #42367
Current version: