Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticWebAssets] Improve Up to date check logic #43100

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

javiercn
Copy link
Member

  • Implements specific targets for the up-to-date check for static web assets.

Validated the scenarios manually, since this functionality is tied to VS:

  • Add a file:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).
  • Update a file:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).
  • Remove a file:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).
  • Add a file on a dependent project:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).
  • Update a file on a dependent project:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).
  • Remove a file on a dependent project:
    • Build: Project is not up to date (build).
    • Build: Project becomes up to date (nothing to do).

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 29, 2024
@javiercn javiercn force-pushed the javiercn/improve-up-to-date-check branch 2 times, most recently from 149ac5e to 9d4bfbe Compare August 30, 2024 15:11
@javiercn javiercn force-pushed the javiercn/improve-up-to-date-check branch from 9d4bfbe to c7ff3ac Compare August 30, 2024 20:32
@javiercn javiercn marked this pull request as ready for review August 30, 2024 20:37
@javiercn javiercn requested a review from a team as a code owner August 30, 2024 20:37
@javiercn javiercn merged commit f271b05 into main Aug 31, 2024
37 checks passed
@javiercn javiercn deleted the javiercn/improve-up-to-date-check branch August 31, 2024 09:40
@javiercn
Copy link
Member Author

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10644272725

@javiercn javiercn linked an issue Sep 2, 2024 that may be closed by this pull request
@mkArtakMSFT mkArtakMSFT added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch and removed Area-Infrastructure untriaged Request triage from a team member labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blazor] Build acceleration breaks blazor web apps.
3 participants