We're currently copying the test assets to the publish directory #43146
Conversation
…very single test project which is duplicating a lot of files in our PR builds. This is also leading to some .tmp file missing copy issues from the parallel builds I'm not sure why these files are specifically included so let's try removing them and see what fails.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
I have no earthly idea why this wasn't there before. When I dug into the code, it fell into that else path because of how it, I believe, uses environment variables to set certain values when running in Helix. I put a comment here on Will's PR to add Helix support when I was investing this stuff before. Anyway, if this PR works, then go for it.
Yeah, I'm not sure why some changes didn't work before but this is passing now. Maybe something else changed in between. I want to test local test build before I merge this just in case (don't want to cause local dev tests run to fail just to fix helix runs). And RE comment in Will's PR, I think the initial testexecutiondirectory set can just be deleted...may be worth trying in a separate PR just to clean it up. |
|
Ran a bunch of tools tests locally and they passed so I think this is good for helix and local dev. I didn't test local helix but that config is already fairly challenging to get set up. |
for every single test project which is duplicating a lot of files in our PR builds.
This is also leading to some .tmp file missing copy issues from the parallel builds I'm not sure why these files are specifically included so let's try removing them and see what fails.