Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand EOL list to include net7 6 months after it goes OOS per design #43440

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Sep 13, 2024

Summary

When a version of .NET goes out of support, we add a gold bar in Visual Studio when customers open a project targeting that version and we mark it out of support in the UI. However, to give customers time to migration, we don't mark it as a warning in builds for 6 months as otherwise, customers with warnings as errors would be broken immediately.

Customer Impact

Customers targeting net7.0 will get a warning that the runtime is out of support. They can upgrade, suppress the warning, or set a property to disable the warning.

Regression

Intentional change

Testing

Automated. Had to modify a few tests to remove the net7.0 targeting or disable the warning.

Risk

Low.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Sep 13, 2024
@marcpopMSFT
Copy link
Member Author

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10855800411

Disable the EOL message for two publishing tests
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner September 16, 2024 17:23
@marcpopMSFT
Copy link
Member Author

@MichalStrehovsky @LakshanF I went ahead and just disabled the new warning in the two AOT tests that hit net7. Let me know if you've rather just have those tests no longer target net 7. I make the change here and #43441. The plan is to merge for GA.

@marcpopMSFT marcpopMSFT removed the untriaged Request triage from a team member label Sep 18, 2024
@marcpopMSFT marcpopMSFT added the breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug label Oct 8, 2024
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@marcpopMSFT marcpopMSFT merged commit a359a4c into release/8.0.1xx Oct 9, 2024
17 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-expandeolto8 branch October 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Branch Lockdown breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug needs-breaking-change-doc-created Servicing-consider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants