Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] make error for workload info clean Fixes #42581 #43587

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2024

Backport of #42630 to release/9.0.2xx

/cc @dsplaisted @Forgind

This is a backport of a fix to an issue where an exception would be displayed in dotnet workload --info when a workload set specified in global.json was not found, and when there was at least one workload installed.

In addition to the backport, this PR refactors how the workload state is reported, normalizes some of the messages in different scenarios, and adds a test for the failing case.

@dsplaisted dsplaisted requested a review from a team September 20, 2024 19:46
@dsplaisted
Copy link
Member

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT marcpopMSFT added this to the 9.0.2xx milestone Sep 24, 2024
@marcpopMSFT marcpopMSFT changed the base branch from release/9.0.1xx to release/9.0.2xx September 24, 2024 23:18
@dsplaisted dsplaisted merged commit ba8eb23 into release/9.0.2xx Oct 4, 2024
31 checks passed
@dsplaisted dsplaisted deleted the backport/pr-42630-to-release/9.0.1xx branch October 4, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants