Increase Arm64 test build timeout #44595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
joeloff
approved these changes
Nov 1, 2024
dsplaisted
approved these changes
Nov 1, 2024
|
@joeloff @dsplaisted It seems I set the wrong timeout. I need to figure out how to set the timeout inside the Helix run itself; not for the job. The job default timeout is actually 150 minutes. So, let me look that up and I'll update the PR. Looking at the Helix logs, they do: Edit: Found where it is set: Line 11 in 83be940 |
joeloff
approved these changes
Nov 1, 2024
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/sdk/actions/runs/11638170341 |
|
@MiYanni backporting to main failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Increased the timeout for Arm64 test builds to 90 minutes.
Using index info to reconstruct a base tree...
M .vsts-ci.yml
M .vsts-pr.yml
Falling back to patching base and 3-way merge...
Auto-merging .vsts-pr.yml
CONFLICT (content): Merge conflict in .vsts-pr.yml
Auto-merging .vsts-ci.yml
CONFLICT (content): Merge conflict in .vsts-ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Increased the timeout for Arm64 test builds to 90 minutes.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@MiYanni an error occurred while backporting to main, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up to this PR where we added the Arm64 test build, I notice it regularly times out. I think it is on the cusp of hitting the
6045 minute default timeout for a Helix run, so it sometimes takes longer and sometimes doesn't. So, I decided to up the timeout to9060 minutes. If we hit the timeout period after this change, then there is probably a bigger concern.I will also forwardport this to
main.