Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] improve SDK incremental builds by not running crossgen on inner loop builds #44726

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[release/9.0.1xx] improve SDK incremental builds by not running crossgen on inner loop builds #44726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6083f01
improve SDK incremental builds by not running crossgen on inner loop …
baronfel Nov 6, 2024
5852fb8
use existing DISABLE_CROSSGEN settings
baronfel Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ echo %* | findstr /C:"-pack" >nul
if %errorlevel%==0 (
set PackInstaller=
) else (
REM disable crossgen for inner-loop builds to save a ton of time
set PackInstaller=/p:PackInstaller=false
set DISABLE_CROSSGEN=true
)
powershell -NoLogo -NoProfile -ExecutionPolicy ByPass -command "& """%~dp0eng\common\build.ps1""" -restore -build -nativeToolsOnMachine -msbuildEngine dotnet %PackInstaller% %*"
exit /b %ErrorLevel%
2 changes: 2 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ done
ScriptRoot="$( cd -P "$( dirname "$SOURCE" )" && pwd )"

if [[ "$@" != *"-pack"* ]]; then
# disable crossgen for inner-loop builds to save a ton of time
export DISABLE_CROSSGEN=true
packInstallerFlag="/p:PackInstaller=false"
else
packInstallerFlag=
Expand Down
2 changes: 1 addition & 1 deletion src/Installer/redist-installer/targets/GenerateLayout.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@

<Target Name="GenerateInternalLayout"
DependsOnTargets="GenerateLayout"
BeforeTargets="AfterBuild">
BeforeTargets="AfterBuild" >
<RemoveDir Directories="$(SdkInternalLayoutPath)" />
<MakeDir Directories="$(SdkInternalLayoutPath)" />

Expand Down
Loading