Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow reading all mcr image names #44738

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Nov 8, 2024

Fixes #44732

The original check was just a bit too strict - other tools may use MCR-provided images that aren't from dotnet/, like azure-functions/, so in order to categorize that usage we need to loosen the check just a bit.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Nov 8, 2024
@baronfel baronfel requested a review from a team November 8, 2024 03:52
@baronfel baronfel merged commit b730d86 into dotnet:main Jan 11, 2025
38 checks passed
@baronfel baronfel deleted the recognize-all-mcr-images branch January 11, 2025 20:49
@baronfel
Copy link
Member Author

/backport to release/9.0.2xx

Copy link
Contributor

Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/12727498212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK Containerization base image telemetry to account for Azure Functions base image usage
2 participants