Add VMR leg that builds test projects

[ViktorHofer]

Fixes dotnet/source-build#4168

Running as part of the PR to get some initial results.

[ViktorHofer]

src\winforms\src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\ToolStripContentPanelDesignerTests.cs(43,67): error CS8620: (NETCORE_ENGINEERING_TELEMETRY=Build) Argument of type 'string[]' cannot be used for parameter 'span' of type 'Span<string?>' in 'bool MemoryExtensions.Contains<string?>(Span<string?> span, string? value)' due to differences in the nullability of reference types.

@am11 did we see this one when we updated the VMR to the .NET 10 SDK? Can't remember if we talked about it.

[am11]

Yup, it was #43015 (comment). It will probably need a fix like dotnet/winforms@main...am11:winforms:patch-1. I'll try building it on windows soon.

[ViktorHofer]

    D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\CustomConvertersTestBase.cs(1187,49): error CS0023: Operator '.' cannot be applied to operand of type 'void' [D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj]
    D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\CustomConvertersTestBase.cs(1188,49): error CS0023: Operator '.' cannot be applied to operand of type 'void' [D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj]
    D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\Query\PrimitiveCollectionsQueryTestBase.cs(430,67): error CS8620: Argument of type 'string[]' cannot be used for parameter 'span' of type 'Span<string?>' in 'bool MemoryExtensions.Contains<string?>(Span<string?> span, string? value)' due to differences in the nullability of reference types. [D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj]
    D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\Query\PrimitiveCollectionsQueryTestBase.cs(433,68): error CS8620: Argument of type 'string[]' cannot be used for parameter 'span' of type 'Span<string?>' in 'bool MemoryExtensions.Contains<string?>(Span<string?> span, string? value)' due to differences in the nullability of reference types. [D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj]
    D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\Query\PrimitiveCollectionsQueryTestBase.cs(577,67): error CS8620: Argument of type 'string[]' cannot be used for parameter 'span' of type 'Span<string?>' in 'bool MemoryExtensions.Contains<string?>(Span<string?> span, string? value)' due to differences in the nullability of reference types. [D:\a\_work\1\vmr\src\efcore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj]

@am11 would you want to help me with driving this one in? I currently have some other obligations and won't be able to get back to this PR anytime soon. See the above efcore test failure. They need the same first class Span reaction update.

There's also a winforms test failure in the PR that I don't really understand yet.

[am11]

I think #44922 is bringing winforms change. I'll check efcore.

[ViktorHofer]

The efcore issue is weird:

2024-11-20T20:05:12.6651643Z     FSC : error FS2014: A problem occurred writing the binary 'D:\a\_work\1\vmr\src\efcore\artifacts\obj\EFCore.FSharp.FunctionalTests\Release\net9.0\refint\Microsoft.EntityFrameworkCore.FSharp.FunctionalTests.dll': A call to StrongNameSignatureSize failed (Invalid Public Key blob) [D:\a\_work\1\vmr\src\efcore\test\EFCore.FSharp.FunctionalTests\EFCore.FSharp.FunctionalTests.fsproj]

The winforms failure is also still happening.

[am11]

Looks like a known bug dotnet/fsharp#17451. A solution (workaround?) is here dotnet/fsharp#11546 (comment).

Since it is a test assembly perhaps we should just disable strong name signing?

[ViktorHofer]

It would be interesting to understand why the fsharp test build behaves differently with the VMR.

[NikolaMilosavljevic]

efcore issue is caused by /p:FullAssemblySigningSupported=false which is set in VMR build. This causes PublicSign to not be set to false here: https://github.com/dotnet/arcade/blob/2fd9b394c6ef3ad22639d83b8da649c9350f88f6/src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets#L50

I'll try to set PublicSign to false explicitly in this test project.

[ViktorHofer]

cc @mmitche as you approved the Arcade PR: dotnet/arcade#12940 and might have context here.

[mmitche]

I believe this should be conditioned on source-only or non-source only builds, rather than a blanket setting across all VMR builds. That said, I'm slightly uncomfortable with where the setting is put. I think it should actually be in StrongName.targets or generally within the arcade infra, rather than the source build control setup.

[mmitche]

I'll file an issue and open a PR to fix this.

[mmitche]

dotnet/arcade#15301