Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/aspnetcore #44987

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 20, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: 4491d9a4-839d-4af5-f3e4-08d8e97c775d
  • Build: 20241120.5
  • Date Produced: November 20, 2024 10:35:26 PM UTC
  • Commit: 38250c13a7be74dd7525ef69d3fa6f73133f645a
  • Branch: refs/heads/main

…0241120.2

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24570.1 -> To Version 10.0.0-alpha.2.24570.2
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Nov 20, 2024
…0241120.3

Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24570.1 -> To Version 10.0.0-alpha.2.24570.3
@ViktorHofer ViktorHofer enabled auto-merge (squash) November 20, 2024 19:47
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/aspnetcore:

@dotnet/aspnet-build

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/aspnetcore) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@mmitche
Copy link
Member

mmitche commented Nov 20, 2024

@ViktorHofer There are probalby two bugs here. The description bug is that Maestro doesn't correctly update the description over multiple commits. dotnet/arcade-services#4176 is this bug. The second bug is that aspnetcore only produced a subset of packages in their newest build. Well, maybe it produced everything, but the windows manifest is missiung:

image

Probably caused by dotnet/aspnetcore#59068

@ViktorHofer
Copy link
Member

Oh yes that looks like the culprit.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 20, 2024

@ViktorHofer I think it's because the Windows job that tries to publish is always the last build.cmd we run, which happens to be the one that builds installers. Therefore it uses desktop msbuild, which didn't get the publish args: https://github.com/dotnet/aspnetcore/blob/38250c13a7be74dd7525ef69d3fa6f73133f645a/.azure/pipelines/ci.yml#L281-L296

…0241120.4

Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24570.1 -> To Version 10.0.0-alpha.2.24570.4
…0241120.5

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24570.1 -> To Version 10.0.0-alpha.2.24570.5
@dotnet-maestro dotnet-maestro bot merged commit cf19736 into main Nov 21, 2024
42 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-fe6f9f69-8deb-4057-a3d5-1faba76ddb29 branch November 21, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants