Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect apphost being used when publishing for self-contained single-file with NoBuild=true #45060

Closed
wants to merge 1,765 commits into from
Closed

Fix incorrect apphost being used when publishing for self-contained single-file with NoBuild=true #45060

wants to merge 1,765 commits into from

Conversation

elinor-fung
Copy link
Member

The _GetAppHostCreationConfiguration target sets the _UseSingleFileHostForPublish property, which determines if we (re-)create the app using singlefilehost on publish. When publishing with NoBuild=true, the target was not being run, so we bundled using apphost, resulting in an app that was configured to be self-contained but did not actually have the runtime as part of itself.

This change chains the target into the computation for output paths to ensure that the target runs when publishing without building, so that the correct host is used.

See https://developercommunity.visualstudio.com/t/Single-file-self-contained-failing-after/10794374

MiYanni and others added 30 commits November 5, 2024 13:34
@MiYanni
[main] Update dependencies from dotnet/source-build-externals (dotnet…
d06bc34 
…#44639)
@MiYanni
[main] Update dependencies from dotnet/source-build-reference-packages (
3378394 
dotnet#44641)
@MiYanni
[main] Update dependencies from dotnet/sourcelink (dotnet#44642)
552141d
@MiYanni
[main] Update dependencies from dotnet/test-templates (dotnet#44646)
a65827a
@MiYanni
[main] Update dependencies from dotnet/fsharp (dotnet#44648)
befb30c
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
01e3997 
…0241105.8

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 10.0.100-alpha.1.24553.1 -> To Version 10.0.100-alpha.1.24555.8
@edvilme
sln-list: Fix char conversions (dotnet#44661)
ee23b92
@v-wuzhai
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/c…
3176d3d 
…reateProjectTemplatesTargetTo10
@MiYanni
[main] Update dependencies from dotnet/roslyn (dotnet#44644)
08a7dea
@MiYanni
[main] Update dependencies from dotnet/msbuild (dotnet#44640)
51fdb88
@v-wuzhai
Fix capitalization
1f21b51
@v-wuzhai
Update regex pattern based on review feedback
372a651
@v-wuzhai
Add empty line after constructor based on review feedback
566a0cd
@dotnet-maestro
[main] Update dependencies from dotnet/aspnetcore (dotnet#44636)
ae8fdee 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@v-wuzhai
Merge branch 'main' of https://github.com/dotnet/sdk into darc-main-9…
ba781ab 
…05d7b53-17c1-4d7a-826d-46f9121d9fb1
@dotnet-maestro @ViktorHofer
[main] Update dependencies from dotnet/windowsdesktop (dotnet#44650)
2ca49f7 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@v-wuzhai
Fix a bunch of failing tests
4b595f0
@dotnet-maestro @ViktorHofer @v-wuzhai
[main] Update dependencies from dotnet/razor (dotnet#44634)
46c1a0c 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Jason Zhai <v-wuzhai@microsoft.com>
@v-wuzhai
Fix failing template test due to .NET version update
6595efe
@v-wuzhai
[main] Update dependencies from dotnet/templating (dotnet#44663)
f542dd4
@dotnet-maestro @ViktorHofer @v-wuzhai
[main] Update dependencies from dotnet/arcade (dotnet#44638)
e21098f 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Jason Zhai <v-wuzhai@microsoft.com>
@dotnet-maestro @mthalman @ViktorHofer
[main] Update dependencies from dotnet/windowsdesktop (dotnet#44679)
b5a9089 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@NikolaMilosavljevic @ViktorHofer @MichaelSimons
Add package source mappings unit-tests (dotnet#44649)
8b91924 
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Michael Simons <msimons@microsoft.com>
@am11
Fix native install-dependencies.sh ref (dotnet#44686)
c562591
@dotnet-maestro
[main] Update dependencies from dotnet/aspnetcore (dotnet#44690)
2a6bfa2 
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jkoritzinsky
Pass down PublicBaseURL for aspnetcore to direct it to download asset…
a09ad8a 
…s from the local artifacts assets path (dotnet#44692)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/fsharp build 20241…
cadf04a 
…106.3

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 9.0.200-beta.24555.1 -> To Version 9.0.200-beta.24556.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
0a42c09 
…0241106.3

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24556.1 -> To Version 10.0.0-alpha.2.24556.3
@baronfel
Allow ProjectReferences to not have the _GetRequiredWorkloads Target (d…
fbd50ef 
…otnet#44593)
@v-wuzhai
[main] Update dependencies from dotnet/fsharp (dotnet#44697)
0b68452
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ILLink untriaged Request triage from a team member labels Nov 23, 2024
@am11
Copy link
Member

am11 commented Nov 23, 2024

A workaround for SDK 9.0.100 users is to add this block in their project file:

<Target Name="_Workaround_dotnet_sdk_45060" BeforeTargets="_GetComHostPaths">
  <CallTarget Targets="_GetAppHostCreationConfiguration" />
</Target>

@elinor-fung elinor-fung changed the base branch from main to release/9.0.2xx November 26, 2024 22:12
@elinor-fung elinor-fung mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocke agocke Awaiting requested review from agocke

@baronfel baronfel Awaiting requested review from baronfel

@tmat tmat Awaiting requested review from tmat tmat is a code owner

@AntonLapounov AntonLapounov Awaiting requested review from AntonLapounov AntonLapounov is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@vijayrkn vijayrkn Awaiting requested review from vijayrkn vijayrkn is a code owner

Assignees
No one assigned
Labels
Area-ILLink untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.